fix(epoxy): make quorum sizes match paper#4234
Conversation
|
🚅 Deployed to the rivet-pr-4234 environment in rivet-frontend
|
PR Review: fix(epoxy): make quorum sizes match paperSummaryThis PR separates the fanout quorum calculation into its own function ( However, there's a significant concern with the fast quorum formula that deserves attention before merge. Critical: Fast quorum formula may be smaller than EPaxos section 4.3 requiresThe comment cites EPaxos §4.3, which specifies fast quorum size as // Old (correct per EPaxos §4.3)
QuorumType::Fast => (n * 3) / 4 + 1,The new formula uses
The new formula consistently produces fast quorums 1 smaller than the paper's requirement. The EPaxos safety argument depends on any two fast quorums intersecting in at least Concrete impact in the accept phase — in Could you clarify which paper edition this formula comes from, or point to the theorem that justifies the smaller values? If the protocol has diverged from stock EPaxos, a note in the code would help future readers. Minor:
|
788e9db to
e7553c7
Compare
c7242fc to
e418d91
Compare
e7553c7 to
710de07
Compare
e418d91 to
0e4f8dc
Compare
710de07 to
fbd667c
Compare
0e4f8dc to
233582b
Compare
233582b to
682f215
Compare
fbd667c to
6b4b34d
Compare
6b4b34d to
5973cf6
Compare
5973cf6 to
e86f64c
Compare
e86f64c to
a4fe6de
Compare
a4fe6de to
754e84e
Compare
754e84e to
4e3fd8f
Compare
4e3fd8f to
e144ca2
Compare
e144ca2 to
f01fcb4
Compare
02b2c93 to
2d6e590
Compare
f01fcb4 to
0027acd
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: